Adds NUM_TIMES_SAMPLED agent metadata to the submitted profile #34
Conversation
pandpara
left a comment
pandpara
left a comment
There was a problem hiding this comment.
Can you update the minimum samples in a profile to 1 to make it consistent with java agent : https://github.com/aws/amazon-codeguru-profiler-python-agent/blob/main/codeguru_profiler_agent/profiler_disabler.py#L9
| CHECK_KILLSWITCH_FILE_INTERVAL_SECONDS = 60 | ||
| MINIMUM_MEASURES_IN_DURATION_METRICS = 20 | ||
| MINIMUM_SAMPLES_IN_PROFILE = 5 | ||
| MINIMUM_SAMPLES_IN_PROFILE = 1 |
There was a problem hiding this comment.
I know you got this as a comment from @pandpara , but I don't think this should be updated, and especially in this commit. This affects if the profiler is disabled or not and it's different than what the general message of this commit is about. If there's a concern about this value, we can do it in a different commit (even release).
mirelap-amazon
left a comment
mirelap-amazon
left a comment
There was a problem hiding this comment.
One comment about the MINIMUM_SAMPLES_IN_PROFILE
This reverts commit f8dcc6d.
|
Hi Max, could you have a |
4 participants
Description of changes:
Adds serialization logic to submit
total_sample_countas NUM_TIMES_SAMPLED property of the AgentMetadata.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.