Fix bug in module path for Fargate and ignore the "/./" for Windows. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapaPedro
reviewed
Jun 29, 2021
| import os | ||
| # This ignores the first D:. | ||
| # This test just asserts the current behaviour, though the "/./" removal is not set for Windows. | ||
| expected = self.current_path.replace(os.sep, ".")[3:] + ".polls.views" |
Contributor
There was a problem hiding this comment.
I do not understand this, could you explain with a concrete example what we expect for each Windows or other os?
I kind of expected the module path the turn out the same for all os
Contributor
Author
There was a problem hiding this comment.
For Windows I'm not updating the module path because I didn't test uwsgi on Windows, this is just a test to show what it is now.
PapaPedro
approved these changes
Jun 29, 2021
Contributor
PapaPedro
left a comment
PapaPedro
left a comment
There was a problem hiding this comment.
Looks good to me but was a bit confused about one unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I'm reconsidering this change to update the module path only for this specific usecase we've found for uwsgi when the "/./" is added. If other usecases arise, we can add them later.
Testing:
Tested it with the task published and django app from our sample and the Fargate app we have.
Before this change, a frame in the Fargate app looked like
optamazonbinSampleApp:<module>.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.