Fixing bug in calculating active time since start #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of lambda where there are pause times, it should be considered when calculating active time. Essentially total pause time should be removed from [end-start]. Earlier we were considering the last sample time to be the end of the profile but in some corner cases where there is huge pause after that we would include it in the calculation even though pause is after the "end" of the profile. So updating the way we calculate "end" of the profile. For more detailed information, please have a look at the comments. Also, added some debug logs.
mirelap-amazon
suggested changes
Jul 8, 2021
Contributor
mirelap-amazon
left a comment
mirelap-amazon
left a comment
There was a problem hiding this comment.
Change looks good, but please take a look at the failing unit tests.
mirelap-amazon
approved these changes
Jul 8, 2021
PapaPedro
reviewed
Jul 8, 2021
PapaPedro
reviewed
Jul 8, 2021
Contributor
PapaPedro
left a comment
PapaPedro
left a comment
There was a problem hiding this comment.
Looks good to me, I just realized about the other race condition that could happen, not sure it is possible but maybe we could try to handle it too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of lambda where there are pause times, it should be considered when calculating active time. Essentially total pause time should be removed from [end-start]. Earlier we were considering the last sample time to be the end of the profile but in some corner cases where there is huge pause after that we would include it in the calculation even though pause is after the "end" of the profile.
So updating the way we calculate "end" of the profile. For more detailed information, please have a look at the comments.
Also, added some debug logs.