Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs after latest merge #66

Open
extmchristensen opened this issue May 25, 2018 · 0 comments

Comments

@extmchristensen
Copy link

commented May 25, 2018

The latest mergred PR by @jagadeeshaby was great but introduced a few minior issues (in no partiuclar order):

  1. Gulp step won't work unless you also have gulp installed globally. Better to add this section to package.json and ask users to run "npm run gulp" instead.
    "scripts": {
    "gulp": "gulp"
    }

  2. The documentation file still mentions the absolete make file at the top under "Downloading Streams"

  3. The produced stream api file by gulp is misspelled and missing a verson identifier in the filename like the old file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.