New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'mem_limit' with a suffix does not work (e.g. 50M) #1

Closed
euank opened this Issue Oct 7, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@euank
Contributor

euank commented Oct 7, 2015

The following works fine with docker-compose up

web:
    image: nginx
    ports: 
        - "80:80"
    mem_limit: 50M

When using ecs-cli compose up I get the following error repeated 3 times:
FATA[0000] Unable to create and read ECS Compose Project error=strconv.ParseInt: parsing "50M": invalid syntax

You can work around this by using

web:
    image: nginx
    ports: 
        - "80:80"
    mem_limit: 52428800

instead.

@euank euank added the Bug label Oct 7, 2015

@rprieto

This comment has been minimized.

Show comment
Hide comment
@rprieto

rprieto Feb 23, 2016

Support for suffixes would be great, as it currently requires us to change valid docker-compose files (that work locally)... and 52428800 doesn't quite roll off the tongue.

rprieto commented Feb 23, 2016

Support for suffixes would be great, as it currently requires us to change valid docker-compose files (that work locally)... and 52428800 doesn't quite roll off the tongue.

@kaihendry

This comment has been minimized.

Show comment
Hide comment
@kaihendry

kaihendry Jul 27, 2016

The default should be to take as much memory as available, which I think Docker (aka linux containers) does by default (and that's a FEATURE!), but not in ECS. 😞 Having to translate (often changing) instance details http://s.natalian.org/2016-07-27/ecs-instance.png to bytes is a poor UX and fraught with error.

kaihendry commented Jul 27, 2016

The default should be to take as much memory as available, which I think Docker (aka linux containers) does by default (and that's a FEATURE!), but not in ECS. 😞 Having to translate (often changing) instance details http://s.natalian.org/2016-07-27/ecs-instance.png to bytes is a poor UX and fraught with error.

@tiffanyfj

This comment has been minimized.

Show comment
Hide comment
@tiffanyfj

tiffanyfj Jan 4, 2017

Member

If we update the vendor dir for docker/libcompose, this issue will be fixed.

Member

tiffanyfj commented Jan 4, 2017

If we update the vendor dir for docker/libcompose, this issue will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment