Update to support agent version 1.13.0 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
samuelkarp
suggested changes
Sep 27, 2016
| @@ -0,0 +1 @@ | |||
| 1.12.2 | |||
There was a problem hiding this comment.
Can you update this to 1.13.0 and run the update-version.sh script to generate a new version file?
There was a problem hiding this comment.
done. please refresh this PR.
nmeyerhans
force-pushed
the
v1.13.0-1-stage
branch
from
c153a82
to
41b0578
Compare
samuelkarp
suggested changes
Sep 27, 2016
| const GitDirty = true | ||
|
|
||
| // GitShortHash is the short hash of this ecs-init build | ||
| const GitShortHash = "c153a82" |
There was a problem hiding this comment.
I think we missed copying this over in @richardpen's change set, but the update-version.sh script should set this to UNKNOWN. Can you manually change it to UNKNOWN for now and then as a follow up create an issue to handle it?
|
👍 |
samuelkarp
approved these changes
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.