Address initial set of PR comments

Author: Doyoon Kim

pkg/deploy/lattice/targets_manager.go

@@ -67,7 +67,7 @@ func (s *defaultTargetsManager) Update(ctx context.Context, modelTargets *model.
 	}
 	staleTargets := s.findStaleTargets(modelTargets, latticeTargets)
 
-	err1 := s.deregisterStaleTargets(ctx, modelTg, staleTargets)
+	err1 := s.deregisterTargets(ctx, modelTg, staleTargets)
 	err2 := s.registerTargets(ctx, modelTg, modelTargets.Spec.TargetList)
 	return errors.Join(err1, err2)
 }
@@ -131,7 +131,7 @@ func (s *defaultTargetsManager) registerTargets(
 	return registerTargetsError
 }
 
-func (s *defaultTargetsManager) deregisterStaleTargets(
+func (s *defaultTargetsManager) deregisterTargets(
 	ctx context.Context,
 	modelTg *model.TargetGroup,
 	targets []model.Target,

pkg/deploy/lattice/targets_synthesizer.go

@@ -21,6 +21,7 @@ const (
 	ReadinessReasonHealthy                = "Healthy"
 	ReadinessReasonUnhealthy              = "Unhealthy"
 	ReadinessReasonUnused                 = "Unused"
+	ReadinessReasonInitial                = "Initial"
 	ReadinessReasonHealthCheckUnavailable = "HealthCheckUnavailable"
 	ReadinessReasonTargetNotFound         = "TargetNotFound"
 )
@@ -134,7 +135,8 @@ func (t *targetsSynthesizer) syncStatus(ctx context.Context, modelTargets []mode
 				continue
 			}
 
-			// Step 2: Check if the pod readiness condition is owned by controller.
+			// Step 2: Check if the pod readiness condition exists with specific condition type.
+			// The condition is considered false when it does not exist.
 			cond := utils.FindPodStatusCondition(pod.Status.Conditions, LatticeReadinessGateConditionType)
 			if cond != nil && cond.Status == corev1.ConditionTrue {
 				continue
@@ -162,8 +164,12 @@ func (t *targetsSynthesizer) syncStatus(ctx context.Context, modelTargets []mode
 					newCond.Status = corev1.ConditionTrue
 					newCond.Reason = ReadinessReasonHealthCheckUnavailable
 				case vpclattice.TargetStatusUnused:
-					// For ServiceExport TGs, we do not have to evaluate them as Healthy, but we also do not have to requeue.
+					// Since this logic is called after HTTPRoute is wired, this only happens for ServiceExport TGs.
+					// In this case we do not have to evaluate them as Healthy, but we also do not have to requeue.
 					newCond.Reason = ReadinessReasonUnused
+				case vpclattice.TargetStatusInitial:
+					requeue = true
+					newCond.Reason = ReadinessReasonInitial
 				default:
 					requeue = true
 					newCond.Reason = ReadinessReasonUnhealthy

pkg/deploy/lattice/targets_synthesizer_test.go

@@ -150,11 +150,20 @@ func Test_PostSynthesize_Conditions(t *testing.T) {
 			requeue:        false,
 		},
 		{
-			name:           "Unhealthy targets do not make pod ready",
+			name:           "Initial targets do not make pod ready",
 			model:          target,
 			lattice:        newLatticeTarget("10.10.1.1", 8675, vpclattice.TargetStatusInitial),
 			pod:            newPod("ns", "pod1", true, false),
 			expectedStatus: corev1.ConditionFalse,
+			expectedReason: ReadinessReasonInitial,
+			requeue:        true,
+		},
+		{
+			name:           "Unhealthy targets do not make pod ready",
+			model:          target,
+			lattice:        newLatticeTarget("10.10.1.1", 8675, vpclattice.TargetStatusUnhealthy),
+			pod:            newPod("ns", "pod1", true, false),
+			expectedStatus: corev1.ConditionFalse,
 			expectedReason: ReadinessReasonUnhealthy,
 			requeue:        true,
 		},

pkg/utils/pod_condition.go

@@ -18,6 +18,7 @@ func PodHasReadinessGate(pod *corev1.Pod, conditionType corev1.PodConditionType)
 	return false
 }
 
+// Copied from: k8s.io/apimachinery/pkg/apis/meta
 func FindPodStatusCondition(conditions []corev1.PodCondition, conditionType corev1.PodConditionType) *corev1.PodCondition {
 	for i := range conditions {
 		if conditions[i].Type == conditionType {
@@ -27,6 +28,7 @@ func FindPodStatusCondition(conditions []corev1.PodCondition, conditionType core
 	return nil
 }
 
+// Copied from: k8s.io/apimachinery/pkg/apis/meta
 func SetPodStatusCondition(conditions *[]corev1.PodCondition, newCondition corev1.PodCondition) {
 	if conditions == nil {
 		return