Skip to content

Conversation

@xWink
Copy link
Member

@xWink xWink commented Sep 28, 2023

What type of PR is this?

cleanup

Which issue does this PR fix:
#126 partially

What does this PR do / Why do we need it:

  • Removes unnecessary logs
  • Removes cases of log n throw
  • Grammatical improvements to logs
  • Removes embedding structs into logs where not absolutely needed
  • Removes use of glog entirely
  • Change some info logs to error or debug logs

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

Ran 32 of 32 Specs in 2099.127 seconds
SUCCESS! -- 32 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (2100.16s)
PASS
ok      github.com/aws/aws-application-networking-k8s/test/suites/integration   2100.892s

Automation added to e2e:

Will this PR introduce any new dependencies?:

No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this PR introduce any user-facing change?:

Only logging changes


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xWink xWink requested a review from mikhail-aws September 28, 2023 23:09
@xWink
Copy link
Member Author

xWink commented Sep 28, 2023

There will be 1 more PR after this with additional cleanup, since we have a handful of places left that contain unwanted or ugly info logs, needlessly scary error logs, and embedded structs in info logs creating clutter. Keeping those changes out of this PR for the sake of keeping things bite-sized.

@xWink xWink merged commit 6cccaa5 into aws:main Sep 29, 2023
@xWink xWink deleted the logging-4 branch September 29, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants