Upgrade gateway-api@v1.0.0 / controller-runtime@v0.16.3 #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-aws
reviewed
Nov 15, 2023
Comment on lines
+98
to
+99
| Watches(&gwv1beta1.Gateway{}, handler.EnqueueRequestsFromMapFunc(r.findImpactedAccessLogPolicies), pkg_builder.WithPredicates(predicate.GenerationChangedPredicate{})). | ||
| Watches(&gwv1beta1.HTTPRoute{}, handler.EnqueueRequestsFromMapFunc(r.findImpactedAccessLogPolicies), pkg_builder.WithPredicates(predicate.GenerationChangedPredicate{})). |
Contributor
There was a problem hiding this comment.
should we use gwv1 everywhere now? there are other places when we watch for beta version of gw and routes
Contributor
Author
There was a problem hiding this comment.
For max compatibility and safety I don't think we will watch v1 version resource right away. (and actually that is not required to support v1 - this PR is already able to watch them.)
Contributor
There was a problem hiding this comment.
did you run any e2e tests?
Contributor
Author
There was a problem hiding this comment.
Actually I didn't and fixed the e2etest overall, e2etest will run on v1 (instead of v1beta1) resources to prove the controller is capable of handling them.
Contributor
|
very nice enhancements! |
solmonk
force-pushed
the
dependency-upgrade
branch
from
7af1d7f to
f6bd65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
Partially - #469
Fully - #447
Also this removes
gen_mocks.shand unifies mock generation togo generate- should remove a few confusion we had on buildingWhat does this PR do / Why do we need it:
controller-runtime@v0.16.3introduces a few breaking changes, had to fix it but they look good especially for contexts in event handler.If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Confirmed controller is running ok
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.