Fix for leaking target groups on service delete #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikfuller
commented
Nov 17, 2023
| ## Local Development | ||
|
|
||
| A minimal sanity check on changes can be done with make presubmit. This command will also run on PR. | ||
| A minimal test of changes can be done with ```make presubmit```. This command will also run on PR. |
Contributor
Author
There was a problem hiding this comment.
Removed non-inclusive/ableist language here.
mikhail-aws
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug fix
Which issue does this PR fix:
n/a
What does this PR do / Why do we need it:
Target group deletion following service deletion is hitting a race condition where the target group is still considered associated to the service via a listener. This PR removes listeners explicitly prior to service deletion, which should ensure TGs for the service are free to delete.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Race condition sometimes occurs running GRPC end-to-end tests.
Testing done on this change:
updated unit tests
Automation added to e2e:
ran GRPC test
Will this PR introduce any new dependencies?:
no
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
n/a
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.