Add Tagging to lattice target group resource #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M00nF1sh
reviewed
Dec 1, 2022
| createTargetGroupInput.Tags[latticemodel.K8SIsServiceExportKey] = &value | ||
| } else { | ||
| value := latticemodel.K8SIsNotServiceExport | ||
| createTargetGroupInput.Tags[latticemodel.K8SIsServiceExportKey] = &value |
There was a problem hiding this comment.
nit: i prefer string types instead of bool types for extensibility(in case targetGroup needed for other resources)
e.g. Tags[resourceType] = "serviceExport"
There was a problem hiding this comment.
Further, you can use a library to pointer-ify these for you inline: lo.ToPtr(string) or aws.String(string)
ellistarn
reviewed
Dec 1, 2022
Comment on lines
+39
to
+43
| IsServiceExport bool `json:"serviceexport"` | ||
| K8SServiceName string `json:"k8sservice"` | ||
| K8SServiceNamespace string `json:"k8sservicenamespace"` | ||
| K8SHTTPRouteName string `json:"k8shttproutename"` | ||
| K8SHTTPRouteNamespace string `json:"k8shttproutenamespace"` |
There was a problem hiding this comment.
Am I correct in thinking that this is a user facing API?
- We shouldn't be using
k8sin the api field name - The field should use camelcase
- Instead of hardcoding name and namespace, we should use something like this
ref:
kind: HTTPRoute
name: myname
namespace: mynamespace
There was a problem hiding this comment.
these fields are internal.
M00nF1sh
approved these changes
Dec 1, 2022
ellistarn
reviewed
Dec 1, 2022
pkg/model/lattice/targetgroup.go
Outdated
Comment on lines
13
to
14
| K8SIsServiceExport = "true" | ||
| K8SIsNotServiceExport = "false" |
There was a problem hiding this comment.
Suggested change
| K8SIsServiceExport = "true" | |
| K8SIsNotServiceExport = "false" | |
| TrueString = "true" | |
| FalseString = "false" |
ellistarn
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Today, gateway controller create a lattice target group if a K8S service is referenced by K8S
serviceexportobject or referenced by a backendref of a HTTPRoute.By adding the tags, gateway controller can track which
serviceexportandhttproutetriggered creation of target group. And gateway controller can use it to delete unused target groups #15By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.