feat: add pdb and topologySpreadConstraints to helm chart #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikfuller
requested changes
Sep 18, 2024
Contributor
erikfuller
left a comment
erikfuller
left a comment
There was a problem hiding this comment.
Overall looks good, thanks for putting this PR together. I also tested specifying and omitting the different values and everything lines up the way it should.
I just saw the one namespacing issue, also please get up to date with the main branch and we should be good.
erikfuller
approved these changes
Sep 24, 2024
Contributor
erikfuller
left a comment
erikfuller
left a comment
There was a problem hiding this comment.
Thanks for putting this PR together!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add PDB and topologySpreadConstraints to helm chart
Which issue does this PR fix:
What does this PR do / Why do we need it:
To ensure High Availability of gateway controller deployment, this PR adds PDB and topologySpreadConstraints.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Deployed in my eks cluster.
Automation added to e2e:
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.