Skip to content

Fix IAMAuthPolicy reconciliation loop on invalid service name override #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SinghVikram97 merged 2 commits into from
Dec 6, 2025
Merged

Fix IAMAuthPolicy reconciliation loop on invalid service name override #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0186c5c
Fix IAMAuthPolicy reconciliation loop on invalid service name override
Dec 4, 2025
300b140
Merge branch 'main' into vbedi_re_enable_iam_test
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/controllers/iamauthpolicy_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ func (c *IAMAuthPolicyController) reconcileUpsert(ctx context.Context, k8sPolicy
if statusErr := c.ph.UpdateAcceptedCondition(ctx, k8sPolicy, gwv1alpha2.PolicyReasonInvalid, err.Error()); statusErr != nil {
return ctrl.Result{}, statusErr
}
return ctrl.Result{}, nil
}
return ctrl.Result{}, err
}
Expand Down
15 changes: 1 addition & 14 deletions test/suites/integration/iamauthpolicy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,6 @@ var _ = Describe("IAM Auth Policy", Ordered, func() {
})

It("supports targetRef HTTPRoute change from invalid to valid service name override", func() {
Skip("Test skipped")
policy := newPolicy("recovery-test", "HTTPRoute", httpRouteWithInvalidServiceNameOverride.Name)

testK8sPolicy(policy, K8sResults{statusReason: gwv1alpha2.PolicyReasonInvalid})
Expand All @@ -324,19 +323,7 @@ var _ = Describe("IAM Auth Policy", Ordered, func() {
annotationResId: svcId,
}

Eventually(func(g Gomega) (K8sResults, error) {
p := &anv1alpha1.IAMAuthPolicy{}
err := testFramework.Client.Get(ctx, client.ObjectKeyFromObject(policy), p)
if err != nil {
return K8sResults{}, err
}
return K8sResults{
statusReason: GetPolicyStatusReason(p),
annotationResType: p.Annotations[controllers.IAMAuthPolicyAnnotationType],
annotationResId: p.Annotations[controllers.IAMAuthPolicyAnnotationResId],
}, nil
}).WithTimeout(120 * time.Second).WithPolling(time.Second).
Should(Equal(wantResults))
testK8sPolicy(policy, wantResults)
testLatticeSvcPolicy(svcId, vpclattice.AuthTypeAwsIam, policy.Spec.Policy)

testFramework.ExpectDeletedThenNotFound(ctx, policy)
Expand Down
Loading