From 98fd69ac9dcedab205dc9a8e17c789f1e4534677 Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Tue, 30 May 2023 12:42:41 +0100 Subject: [PATCH] fix(aws-cdk-lib): attribute `FindingsFilterListItems` on AWS::Macie::FindingsFilter does not work (#25778) The attribute was removed in a recent CFN Spec update. We had then patched the attribute and type back in to avoid a breaking change. Now I have confirmed with the service team that this attribute has actually never worked and the removal is indeed correct. Update CDK to reflect the fix made in CloudFormation. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- .../@aws-cdk/cfnspec/skip-evolution-check.txt | 3 +- .../912_Macie_FindingsFilter_patch.json | 44 ------------------- 2 files changed, 2 insertions(+), 45 deletions(-) delete mode 100644 packages/@aws-cdk/cfnspec/spec-source/specification/000_cfn/912_Macie_FindingsFilter_patch.json diff --git a/packages/@aws-cdk/cfnspec/skip-evolution-check.txt b/packages/@aws-cdk/cfnspec/skip-evolution-check.txt index 725fe7f1f113e..99b85260a1289 100644 --- a/packages/@aws-cdk/cfnspec/skip-evolution-check.txt +++ b/packages/@aws-cdk/cfnspec/skip-evolution-check.txt @@ -1,2 +1,3 @@ # to fully skip spec evolution checks, put the PR number in this file. -25326 \ No newline at end of file +25326 +25778 diff --git a/packages/@aws-cdk/cfnspec/spec-source/specification/000_cfn/912_Macie_FindingsFilter_patch.json b/packages/@aws-cdk/cfnspec/spec-source/specification/000_cfn/912_Macie_FindingsFilter_patch.json deleted file mode 100644 index 05c1208096804..0000000000000 --- a/packages/@aws-cdk/cfnspec/spec-source/specification/000_cfn/912_Macie_FindingsFilter_patch.json +++ /dev/null @@ -1,44 +0,0 @@ -{ - "PropertyTypes": { - "patch": { - "description": "Undoing upstream property type removal of Macie.", - "operations": [ - { - "op": "add", - "path": "/AWS::Macie::FindingsFilter.FindingsFilterListItem", - "value": { - "Properties": { - "Id": { - "PrimitiveType": "String", - "Required": false, - "UpdateType": "Mutable" - }, - "Name": { - "PrimitiveType": "String", - "Required": false, - "UpdateType": "Mutable" - } - } - } - } - ] - } - }, - "ResourceTypes": { - "AWS::Macie::FindingsFilter": { - "patch": { - "description": "Undoing upstream attribute removal of Macie. Replaces patch #560.", - "operations": [ - { - "op": "add", - "path": "/Attributes/FindingsFilterListItems", - "value": { - "PrimitiveItemType": "Json", - "Type": "List" - } - } - ] - } - } - } -}