From ccbb6ddd5e5659dab4466a179895c041fefeaf66 Mon Sep 17 00:00:00 2001 From: Elad Ben-Israel Date: Wed, 3 Apr 2019 17:06:51 +0300 Subject: [PATCH] chore: rewrite "updating all dependencies" section in contribution guide (#2172) --- CONTRIBUTING.md | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index adc2e67ac93ea..5a1a1dc4f5355 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -355,18 +355,12 @@ Cycle: @aws-cdk/aws-sns => @aws-cdk/aws-lambda => @aws-cdk/aws-codecommit => @aw ### Updating all Dependencies -We use `npm update` to - -1. Obtain a fresh clone from “master” -2. Run `./install.sh` and `./build.sh` to make sure the current HEAD is not broken (should never be...). -3. Once build succeeded, run: - ```shell - $ npm update # to update the root deps - $ lerna exec npm update # to update deps in all modules - ``` -4. This will probably install some new versions and update `package.json` and `package-lock.json` files. -5. Now, run `./build.sh` again to verify all tests pass. -6. Submit a Pull Request. +To update all dependencies (without bumping major versions): + +1. Obtain a fresh clone from "master". +2. Run `./install.sh` +2. Run `./scripts/update-dependencies.sh --mode full` (use `--mode semver` to avoid bumping major versions) +3. Submit a Pull Request. ### Troubleshooting common issues