Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(synthetics): Add new runtimes #11870

Closed
1 of 2 tasks
flochaz opened this issue Dec 4, 2020 · 2 comments · Fixed by #11866
Closed
1 of 2 tasks

(synthetics): Add new runtimes #11870

flochaz opened this issue Dec 4, 2020 · 2 comments · Fixed by #11866
Assignees
@NetaNir
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@flochaz
Copy link
Contributor

flochaz commented Dec 4, 2020

AWS Cloudwatch synthetics now support two newer version of the nodejs runtime and one new python one.

Would be great to have it available in the aws-synthetics construct

Use Case

Use latest Cloudwatch synthetics feature

Proposed Solution

Add new runtimes ref

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@flochaz flochaz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2020
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Dec 4, 2020
@flochaz flochaz mentioned this issue Dec 4, 2020
Merged
@NetaNir NetaNir added effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Dec 5, 2020

commented on the PR, adding here for visibility.

The Canary module assume the runtime is always Nodejs, and enforce the below:

  1. The Canary code does include node_moduels folder. See synthetics docs: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_WritingCanary_Nodejs.html
  2. The handler file is named index.handler

Before we introduce Python as runtime we need to address it. Im happy to accept a PR which adds the new node runtime in the meantime
#11866 (review)

@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Dec 7, 2020
@SomayaB SomayaB added the p2 label Dec 21, 2020
@mergify mergify bot closed this as completed in #11866 Jan 7, 2021
mergify bot pushed a commit that referenced this issue Jan 7, 2021
@flochaz
feat(synthetics): Update Cloudwatch Synthetics canaries NodeJS runtim…
4f6e377 
…es (#11866)

Cloudwatch Synthetics recently released new NodeJS runtimes (https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html).

This PR is adding them and update doc links

Fixes #11870

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NetaNir NetaNir

Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(synthetics): Update Cloudwatch Synthetics canaries NodeJS runtimes flochaz/aws-cdk
3 participants
@flochaz @NetaNir @SomayaB