Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ec2): add metadata for M6gd and R6gd instance types #12301

Closed
1 of 2 tasks
Jacob-Doetsch opened this issue Jan 1, 2021 · 1 comment · Fixed by #12302
Closed
1 of 2 tasks

(ec2): add metadata for M6gd and R6gd instance types #12301

Jacob-Doetsch opened this issue Jan 1, 2021 · 1 comment · Fixed by #12302
Assignees
@rix0rrr
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@Jacob-Doetsch
Copy link
Contributor

Jacob-Doetsch commented Jan 1, 2021 •
edited

As of v1.80, we don't yet have M6gd and R6gd available in the ec2 module. The C6gd instance type has already been added, however.

Use Case

These instance types were announced in July 2020, https://aws.amazon.com/about-aws/whats-new/2020/07/announcing-new-amazon-ec2-instances-powered-aws-graviton2-processors/ . The C6gd instance type has already been added but we don't have it's sibling instance types in the ec2 module.

Proposed Solution

Add M6gd and R6gd to the InstanceType enum.

Other

Proposed solution is #12302

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@Jacob-Doetsch Jacob-Doetsch added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 1, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jan 1, 2021
@Jacob-Doetsch Jacob-Doetsch mentioned this issue Jan 1, 2021
Merged
Jacob-Doetsch added a commit to Jacob-Doetsch/aws-cdk that referenced this issue Jan 1, 2021
@Jacob-Doetsch
feat(ec2): add m6gd and r6gd metadata
f9d836f 
closes aws#12301
Jacob-Doetsch added a commit to Jacob-Doetsch/aws-cdk that referenced this issue Jan 3, 2021
@Jacob-Doetsch
feat(ec2): add m6gd and r6gd metadata
2b32197 
closes aws#12301
@mergify mergify bot closed this as completed in #12302 Jan 4, 2021
mergify bot pushed a commit that referenced this issue Jan 4, 2021
@Jacob-Doetsch
feat(ec2): add m6gd and r6gd metadata (#12302)
ce4eb20 
Closes #12301 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@Jacob-Doetsch @flochaz
feat(ec2): add m6gd and r6gd metadata (aws#12302)
f746095 
Closes aws#12301 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@funguy-tech funguy-tech mentioned this issue Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ec2): add m6gd and r6gd metadata Jacob-Doetsch/aws-cdk
2 participants
@rix0rrr @Jacob-Doetsch