Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-notifications): cannot use imported lambda ("fromArn") as a destination #5599

Merged
merged 2 commits into from Jan 5, 2020

Conversation

wcauchois
Copy link
Contributor

fixes #5592


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title fix(s3n): s3n lambda destination works with function by arn fix(s3-notifications): cannot use imported lambda ("fromArn") as a destination Jan 5, 2020
eladb
eladb previously approved these changes Jan 5, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the contribution ❤️

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot dismissed eladb’s stale review January 5, 2020 08:24

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb merged commit 7ceee6d into aws:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 notifications lambda destination does not work with Function.fromFunctionArn
3 participants