Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-python): support poetry packaging for PythonFunction #11850

Merged
merged 14 commits into from Dec 4, 2020

Conversation

setu4993
Copy link
Contributor

@setu4993 setu4993 commented Dec 3, 2020

This PR adds poetry support to building Lambda dependencies for the PythonFunction.

I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something.

Closes #11753.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 3, 2020

eladb
eladb previously requested changes Dec 3, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Minor request about integ tests (would be great if you could consolidate the other tests as well).

Please refer to the contribution guide for more info about integ tests.

@mergify mergify bot dismissed eladb’s stale review December 4, 2020 08:43

Pull request has been modified.

@setu4993
Copy link
Contributor Author

setu4993 commented Dec 4, 2020

@eladb : Replaced the multiple files for integration tests with a single file that has multiple functions.

Happy to consolidate the various pipenv tests into a single file in a separate PR in the next few days, since I do feel that'd be outside the scope of this PR.

@setu4993
Copy link
Contributor Author

setu4993 commented Dec 4, 2020

Also wanted to mention that I couldn't actually run yarn integ in GitPod which kept complaining about unavailability of Docker socket (Docker-in-Docker doesn't appear to be supported in GitPod), so wasn't sure how to test it except with the CodeBuild CI.

@setu4993
Copy link
Contributor Author

setu4993 commented Dec 4, 2020

Thank you, @eladb!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1671c3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c5c258a into aws:master Dec 4, 2020
@setu4993 setu4993 deleted the feature/aws-lambda-python-poetry branch December 4, 2020 10:09
mergify bot pushed a commit that referenced this pull request Dec 6, 2020
…1891)

Following the request from @eladb in #11850 (review), consolidating some of the integration tests in the package.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
skiyani pushed a commit to skiyani/aws-cdk that referenced this pull request Dec 7, 2020
…#11850)

This PR adds [poetry](https://python-poetry.org/) support to building Lambda dependencies for the PythonFunction.

I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something.

Closes aws#11753.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
skiyani pushed a commit to skiyani/aws-cdk that referenced this pull request Dec 7, 2020
…s#11891)

Following the request from @eladb in aws#11850 (review), consolidating some of the integration tests in the package.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
…#11850)

This PR adds [poetry](https://python-poetry.org/) support to building Lambda dependencies for the PythonFunction.

I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something.

Closes aws#11753.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
…s#11891)

Following the request from @eladb in aws#11850 (review), consolidating some of the integration tests in the package.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-lambda-python): Manage dependencies with Poetry
3 participants