Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): Pass bootstrap.sh args to avoid DescribeCluster call and make nodes join the cluster faster #12659

Merged
merged 3 commits into from Apr 15, 2021

Conversation

@anguslees
Copy link
Contributor

@anguslees anguslees commented Jan 22, 2021

Pass sufficient information to bootstrap.sh in ASG user-data, to
prevent it from making a DescribeCluster AWS API call. This per-node
API call can become an issue in large clusters, and we already have
all the information to avoid it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Jan 22, 2021

@anguslees anguslees force-pushed the anguslees:eks-bootstrap-args branch 3 times, most recently from 0de3128 to 76d4f66 Jan 22, 2021
@anguslees anguslees force-pushed the anguslees:eks-bootstrap-args branch from 76d4f66 to 484af9e Feb 8, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Feb 15, 2021

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Feb 15, 2021

dont close

@github-actions
Copy link

@github-actions github-actions bot commented Feb 24, 2021

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Feb 24, 2021

@anguslees Are you still keeping an eye out on this PR?

@anguslees anguslees force-pushed the anguslees:eks-bootstrap-args branch 2 times, most recently from aba42bd to aabeaf0 Mar 31, 2021
Pass sufficient information to bootstrap.sh in ASG user-data, to
prevent it from making a DescribeCluster AWS API call.  This per-node
API call can become an issue in large clusters, and we already have
all the information to avoid it.
@anguslees anguslees force-pushed the anguslees:eks-bootstrap-args branch from aabeaf0 to c95bc09 Apr 12, 2021
@mergify mergify bot dismissed iliapolo’s stale review Apr 12, 2021

Pull request has been modified.

@iliapolo iliapolo changed the title feat(eks): Pass bootstrap.sh args to avoid DescribeCluster call feat(eks): Pass bootstrap.sh args to avoid DescribeCluster call and make nodes join the cluster faster Apr 15, 2021
@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed iliapolo’s stale review Apr 15, 2021

Pull request has been modified.

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 15, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d9ed213
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f5616cc into aws:master Apr 15, 2021
7 checks passed
7 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@mergify
Rule: automatic merge (merge) The pull request has been merged automatically
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 5 potential rules
Details
@anguslees anguslees deleted the anguslees:eks-bootstrap-args branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants