feat(neptune): high level constructs for db clusters and instances #12763
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
- This change adds higher level constructs for Neptune clusters - Adds higher-level constructs for - AWS::Neptune::DBCluster - AWS::Neptune::DBInstance - AWS::Neptune::DBClusterParameterGroup - AWS::Neptune::DBParameterGroup - AWS::Neptune::DBSubnetGroup fixes #12762
Wow, thanks for this contribution!
It's going to take me a few days to have the time to dive deep into this, but I've given it a quick skim and it looks like it's in really great shape. I imagine this is heavily inspired/borrowed from the RDS module.
One point of note is that the description claims this provides the high-level constructs for clusters and instances, but I'm only seeing "L2s" for the cluster. That's totally fine; this is big enough as-is, and we should be able to add in the instances later. I just wanted to clarify intent.
Another minor high-level note is that the pattern of
Lastly, we'll want to add more detail to the README to cover some of the other usage/elements. It doesn't need to be 100% comprehensive, but a bit more than is currently there I think is necessary to get folks up and running quickly.
I'll circle back around (hopefully) next week to do the first pass on the code itself.
Thanks Nick for taking a quick pass at this (yes, code is inspired (read: copied
Good point regarding the instances - I was initially thinking of adding a L2 construct for that but didn't end up doing it because most customers just pick the no. of instances and let the service figure out the distribution. But it might be worth adding if someone wants to give specific names to instances or launch them in specific availability zones. I will take a stab at this, will get rid of current