Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cognito): user pools - sign in with apple #13160

Merged

Conversation

@piotrmoszkowicz
Copy link
Contributor

@piotrmoszkowicz piotrmoszkowicz commented Feb 19, 2021

Added Sign In With Apple provider to @aws-cdk/aws-cognito. That's my first PR here, so bear with me, I hope I haven't made any mistakes, I've been following the docs carefully :)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Feb 19, 2021

@nija-at nija-at changed the title feat(aws-cognito): Add Sign In With Apple feat(cognito): user pools - sign in with apple Feb 25, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Thanks for taking the time and submitting this PR 😊
See my comments below

Could you also add an integ test similar to this - https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-cognito/test/integ.user-pool-idp.amazon.ts ?
Take a look at the stack verification steps on that test. Add ones similar to that to the test.

packages/@aws-cdk/aws-cognito/README.md Outdated Show resolved Hide resolved
@piotrmoszkowicz piotrmoszkowicz requested a review from nija-at Feb 25, 2021
@piotrmoszkowicz
Copy link
Contributor Author

@piotrmoszkowicz piotrmoszkowicz commented Feb 25, 2021

@nija-at Adjusted the code according to your instructions ;)

@mergify mergify bot dismissed nija-at’s stale review Feb 25, 2021

Pull request has been modified.

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed nija-at’s stale review Mar 1, 2021

Pull request has been modified.

@piotrmoszkowicz
Copy link
Contributor Author

@piotrmoszkowicz piotrmoszkowicz commented Mar 1, 2021

@nija-at Test hasn't passed due change in default retention policy for aws-cognito. Therefor the json wasn't up-to-date. I've updated it, tests shall pass now 🤞

@nija-at
nija-at approved these changes Mar 3, 2021
@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Mar 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a47e804
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b965589 into aws:master Mar 3, 2021
7 checks passed
7 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@mergify
Rule: automatic merge (merge) The pull request has been merged automatically
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 5 potential rules
Details
This was referenced Mar 8, 2021
cornerwings added a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
Added Sign In With Apple provider to `@aws-cdk/aws-cognito`. That's my first PR here, so bear with me, I hope I haven't made any mistakes, I've been following the docs carefully :)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants