feat(cognito): user pools - sign in with apple#13160
feat(cognito): user pools - sign in with apple#13160mergify[bot] merged 12 commits intoaws:masterfrom
Conversation
nija-at
left a comment
There was a problem hiding this comment.
Thanks for taking the time and submitting this PR 😊
See my comments below
Could you also add an integ test similar to this - https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-cognito/test/integ.user-pool-idp.amazon.ts ?
Take a look at the stack verification steps on that test. Add ones similar to that to the test.
…ub.com/piotrmoszkowicz/aws-cdk into piotrmoszkowicz/add-sign-in-with-apple
|
@nija-at Adjusted the code according to your instructions ;) |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@nija-at Test hasn't passed due change in default retention policy for |
…zkowicz/add-sign-in-with-apple
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Added Sign In With Apple provider to `@aws-cdk/aws-cognito`. That's my first PR here, so bear with me, I hope I haven't made any mistakes, I've been following the docs carefully :) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Added Sign In With Apple provider to
@aws-cdk/aws-cognito. That's my first PR here, so bear with me, I hope I haven't made any mistakes, I've been following the docs carefully :)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license