Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigatewayv2): http api - default authorizer options #13172

Merged
merged 31 commits into from Mar 17, 2021

Conversation

@iRoachie
Copy link
Contributor

@iRoachie iRoachie commented Feb 21, 2021

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Feb 21, 2021

Copy link
Contributor

@nija-at nija-at left a comment

Thanks for submitting this PR @iRoachie. See my first round of comments below.

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review Feb 25, 2021

Pull request has been modified.

Copy link
Contributor

@nija-at nija-at left a comment

This is all looking great @iRoachie. Just some simple comments below around naming, docs and testing.

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
iRoachie and others added 2 commits Feb 26, 2021
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review Feb 26, 2021

Pull request has been modified.

Copy link
Contributor

@nija-at nija-at left a comment

Cod looks good. Could you make the README change you suggested?

Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Copy link
Contributor

@nija-at nija-at left a comment

Setting this back to request changes for the suggested README updates.

@mergify mergify bot dismissed nija-at’s stale review Mar 10, 2021

Pull request has been modified.

@iRoachie iRoachie requested a review from nija-at Mar 10, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Thanks @iRoachie for cleaning up the README.
Some comments and suggestions on the contents.

Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review Mar 10, 2021

Pull request has been modified.

iRoachie and others added 2 commits Mar 10, 2021
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed nija-at’s stale review Mar 14, 2021

Pull request has been modified.

@iRoachie
Copy link
Contributor Author

@iRoachie iRoachie commented Mar 15, 2021

Updated upstream integ test

@iRoachie iRoachie requested a review from nija-at Mar 15, 2021
@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Mar 17, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c96dfe5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 53d9661 into aws:master Mar 17, 2021
7 checks passed
7 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@mergify
Rule: automatic merge (merge) The pull request has been merged automatically
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 5 potential rules
Details
@iRoachie
Copy link
Contributor Author

@iRoachie iRoachie commented Mar 17, 2021

Thanks again @nija-at 💯

@iRoachie iRoachie deleted the iRoachie:ft/default-authorizer branch Mar 17, 2021
hollanddd added a commit to hollanddd/aws-cdk that referenced this pull request Mar 17, 2021
Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd added a commit to hollanddd/aws-cdk that referenced this pull request Mar 18, 2021
Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants