feat(apigatewayv2): http api - default authorizer options by iRoachie · Pull Request #13172 · aws/aws-cdk

iRoachie · 2021-02-21T02:24:27Z

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

gitpod-io · 2021-02-21T02:24:29Z

nija-at

Thanks for submitting this PR @iRoachie. See my first round of comments below.

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

Pull request has been modified.

nija-at

This is all looking great @iRoachie. Just some simple comments below around naming, docs and testing.

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

packages/@aws-cdk/aws-apigatewayv2/lib/http/route.ts

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

packages/@aws-cdk/aws-apigatewayv2/test/http/api.test.ts

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

Pull request has been modified.

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

nija-at

Cod looks good. Could you make the README change you suggested?

packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

nija-at

Setting this back to request changes for the suggested README updates.

Pull request has been modified.

nija-at

Thanks @iRoachie for cleaning up the README.
Some comments and suggestions on the contents.

packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

Pull request has been modified.

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

mergify · 2021-03-10T18:25:59Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

iRoachie · 2021-03-15T01:54:57Z

Updated upstream integ test

mergify · 2021-03-17T09:35:41Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2021-03-17T10:10:15Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2021-03-17T10:45:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: c96dfe5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2021-03-17T10:45:37Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

iRoachie · 2021-03-17T11:02:05Z

Thanks again @nija-at 💯

@nija-at

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api. @nija-at this is the bit we forgot In the first PR. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@nija-at

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api. @nija-at this is the bit we forgot In the first PR. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@nija-at

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api. @nija-at this is the bit we forgot In the first PR. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(apigatewayv2): http api - default authorizer options

253a9b0

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

github-actions bot assigned nija-at Feb 21, 2021

github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Feb 21, 2021

docs: add example of default settings

105684c

nija-at previously requested changes Feb 25, 2021

View reviewed changes

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved

Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

a953e06

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

iRoachie added 5 commits February 25, 2021 14:08

change route behaviour to override default scopes

51132a3

Add NoneAuthorizer

2404a77

Add docs for NoneAuthorizer

4dceadf

Merge branch 'master' into ft/default-authorizer

3ec0ca9

Add optional default documentation

bae9a27

nija-at previously requested changes Feb 26, 2021

View reviewed changes

iRoachie and others added 2 commits February 26, 2021 10:00

Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

764552c

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

19b1383

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

iRoachie and others added 11 commits February 26, 2021 10:18

prefix internal variable with default keyword

8577089

Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

8e071ae

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

f4dd89b

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

relocate NoneAuthorizer

a97a90e

Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

df0bae2

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

don't set empty authorizationScopes

32aa124

update integ test

9eb1403

update integ tests

0345169

Merge branch 'master' into ft/default-authorizer

ab4a090

update integ test

84bf186

Merge branch 'master' into ft/default-authorizer

c221da5

nija-at previously requested changes Mar 9, 2021

View reviewed changes

packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved

Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts

07e1569

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

nija-at previously requested changes Mar 10, 2021

View reviewed changes

docs: update authorizationr readme

f5ac48a

iRoachie requested a review from nija-at March 10, 2021 13:18

nija-at previously requested changes Mar 10, 2021

View reviewed changes

Update packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md

1660110

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

iRoachie and others added 2 commits March 10, 2021 13:51

Update packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md

f56c52a

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

Update packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md

59f3d52

Co-authored-by: Niranjan Jayakar <nija@amazon.com>

nija-at previously approved these changes Mar 10, 2021

View reviewed changes

mergify bot and others added 2 commits March 10, 2021 18:38

Merge branch 'master' into ft/default-authorizer

62e7e24

Merge branch 'master' into ft/default-authorizer

6a3a44b

update integ

36593ee

iRoachie requested a review from nija-at March 15, 2021 01:55

nija-at approved these changes Mar 17, 2021

View reviewed changes

Merge branch 'master' into ft/default-authorizer

1805a21

Merge branch 'master' into ft/default-authorizer

c96dfe5

mergify bot merged commit 53d9661 into aws:master Mar 17, 2021

iRoachie deleted the ft/default-authorizer branch March 17, 2021 11:02

Conversation

iRoachie commented Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitpod-io bot commented Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nija-at left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nija-at left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nija-at left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nija-at left a comment

Choose a reason for hiding this comment

Uh oh!

nija-at left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Mar 10, 2021

Uh oh!

iRoachie commented Mar 15, 2021

Uh oh!

mergify bot commented Mar 17, 2021

Uh oh!

mergify bot commented Mar 17, 2021

Uh oh!

aws-cdk-automation commented Mar 17, 2021

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Mar 17, 2021

Uh oh!

iRoachie commented Mar 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iRoachie commented Feb 21, 2021 •

edited

Loading

gitpod-io bot commented Feb 21, 2021 •

edited

Loading