Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): integrate with aws services in a different region #13251

Merged
merged 5 commits into from Feb 24, 2021
Merged

feat(apigateway): integrate with aws services in a different region #13251

merged 5 commits into from Feb 24, 2021

Conversation

@otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Feb 24, 2021

This allows the user to choose a different region for the integrated service. By default, the region is the same as the stack's.

Fixes #7009


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This allows the user to choose a different region for the integrated service. By default, the region is the same as the stack's.

Fixes #7009
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Feb 24, 2021

@nija-at nija-at changed the title feat(aws-apigateway): add region to AWSIntegrationProps feat(apigateway): integrate with aws services in a different region Feb 24, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Just one adjustment to the language in the README.

Looks good otherwise.

packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review Feb 24, 2021

Pull request has been modified.

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Feb 24, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e9ef6db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d942699 into aws:master Feb 24, 2021
7 checks passed
7 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@mergify
Rule: automatic merge (merge) The pull request has been merged automatically
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 5 potential rules
Details
@otaviomacedo otaviomacedo deleted the otaviomacedo:apig-integration-region branch Feb 24, 2021
This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants