Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): add imported user to a group #13698

Merged
merged 8 commits into from Apr 22, 2021

Conversation

@jogold
Copy link
Contributor

@jogold jogold commented Mar 19, 2021

Allow adding an imported user to a group by implementing addToGroup() with
AWS::IAM::UserToGroupAddition.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Mar 19, 2021

public addToGroup(_group: IGroup): void {
throw new Error('Cannot add imported User to Group');
public addToGroup(group: IGroup): void {
new CfnUserToGroupAddition(Stack.of(group), `${this.userName}Group${this.groupId}`, {

This comment has been minimized.

@rix0rrr

rix0rrr Mar 23, 2021
Contributor

Woooaahhhh

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review Mar 23, 2021

Pull request has been modified.

@jogold
Copy link
Contributor Author

@jogold jogold commented Mar 23, 2021

@rix0rrr can you reapprove? Looks like node was missing/not correctly configured in the Docker build image for a short period of time.

/root/ecr-proxy/start.sh: line 28: node: command not found

@jogold
Copy link
Contributor Author

@jogold jogold commented Apr 7, 2021

@rix0rrr ping

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 22, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8e7664d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bf513bc into aws:master Apr 22, 2021
7 checks passed
7 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@mergify
Rule: automatic merge (merge) The pull request has been merged automatically
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 5 potential rules
Details
@jogold jogold deleted the jogold:iam-imported-user-add-to-group branch Apr 22, 2021
john-tipper added a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
Allow adding an imported user to a group by implementing `addToGroup()` with
[`AWS::IAM::UserToGroupAddition`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-addusertogroup.html).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants