Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudformation-diff): graduate to stable 馃殌 #13857

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Mar 29, 2021


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 29, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 29, 2021
@NetaNir NetaNir added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-readme The PR linter will not require README changes labels Mar 29, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not stoked by this one, but what are you gonna do...?

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@NetaNir
Copy link
Contributor Author

NetaNir commented Mar 29, 2021

I hear you @skinny85, but we must push through...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b6ff1b9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 294f546 into master Mar 30, 2021
@mergify mergify bot deleted the neta/stable-module branch March 30, 2021 00:01
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 31, 2021
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/cloudformation-diff contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants