Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticsearch): graduate to stable 馃殌 #13900

Merged
merged 8 commits into from Apr 1, 2021

Conversation

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Mar 31, 2021

This PR includes a last minute API change that standardizes the way VPC configuration is passed to the domain. It also provides sane defaults, enabling users to simply pass vpc in order to connect a domain to a VPC.

In addition, I added a missing integration test for VPC enabled domains.

Resolves #10965

BREAKING CHANGE: vpcOptions was removed. Use vpc, vpcSubnets and securityGroups instead.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Mar 31, 2021

@@ -1357,31 +1428,7 @@ describe('custom error responses', () => {

expect(() => new Domain(stack, 'Domain1', {
version: ElasticsearchVersion.V7_4,
vpcOptions: {

This comment has been minimized.

@iliapolo

iliapolo Mar 31, 2021
Author Contributor

This whole config wasn't really needed to assert the test, which validates the availabilityZoneCount property below.

@@ -1150,24 +1228,17 @@ describe('custom endpoints', () => {
describe('custom error responses', () => {

test('error when availabilityZoneCount does not match vpcOptions.subnets length', () => {
const vpc = new Vpc(stack, 'Vpc');
const vpc = new Vpc(stack, 'Vpc', {
maxAzs: 1,

This comment has been minimized.

@iliapolo

iliapolo Mar 31, 2021
Author Contributor

Simpler way to enforce a single AZ.

@iliapolo iliapolo marked this pull request as ready for review Mar 31, 2021
@iliapolo iliapolo marked this pull request as draft Mar 31, 2021
@@ -719,7 +714,7 @@ export interface IDomain extends cdk.IResource {
*
* @default maximum over 1 minute
*/
metricClusterIndexWriteBlocked(props?: MetricOptions): Metric;
metricClusterIndexWritesBlocked(props?: MetricOptions): Metric;
@iliapolo iliapolo marked this pull request as ready for review Mar 31, 2021
@iliapolo iliapolo requested a review from aws/aws-cdk-team Mar 31, 2021
@iliapolo
Copy link
Contributor Author

@iliapolo iliapolo commented Mar 31, 2021

Forgot to actually bump the stability

@eladb
eladb approved these changes Apr 1, 2021
@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1371cf8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 767cd31 into master Apr 1, 2021
7 checks passed
7 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@mergify
Rule: automatic merge (merge) The pull request has been merged automatically
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 1 rule matches and 5 potential rules
Details
@mergify mergify bot deleted the epolon/graduate-elasticsearch branch Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants