Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3-deployment): graduate to stable 馃殌 #13906

Merged
merged 2 commits into from Apr 2, 2021

Conversation

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Mar 31, 2021

Also fixed up some lint violations just for fun.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@@ -70,6 +64,37 @@ By default, the contents of the destination bucket will **not** be deleted when
changed. You can use the option `retainOnDelete: false` to disable this behavior,
in which case the contents will be deleted.

Configuring this has a few implications you should be aware of:

This comment has been minimized.

@iliapolo

iliapolo Mar 31, 2021
Author Contributor

I considered dropping this feature entirely due to these, and instead instruct users to use autoDeleteObjects on the destination bucket.

The problem is that autoDeleteObjects doesn't respect prefixes (nor it should), so its going to delete the entire bucket, while retainOnDelete: false only deletes the specified prefix that it was configured with.

Since our default is true, and we haven't seen any users report these issues, it's probably ok to just surface them a bit and leave as is.

@iliapolo iliapolo requested a review from aws/aws-cdk-team Mar 31, 2021
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Mar 31, 2021

@eladb
eladb approved these changes Apr 1, 2021
@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1eb558f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 567d64d into master Apr 2, 2021
6 checks passed
6 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 1 rule matches and 5 potential rules
Details
@mergify mergify bot deleted the epolon/graduate-s3-deployment branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants