Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3-deployment): graduate to stable 馃殌 #13906

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

iliapolo
Copy link
Contributor

Also fixed up some lint violations just for fun.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 31, 2021
@@ -70,6 +64,37 @@ By default, the contents of the destination bucket will **not** be deleted when
changed. You can use the option `retainOnDelete: false` to disable this behavior,
in which case the contents will be deleted.

Configuring this has a few implications you should be aware of:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered dropping this feature entirely due to these, and instead instruct users to use autoDeleteObjects on the destination bucket.

The problem is that autoDeleteObjects doesn't respect prefixes (nor it should), so its going to delete the entire bucket, while retainOnDelete: false only deletes the specified prefix that it was configured with.

Since our default is true, and we haven't seen any users report these issues, it's probably ok to just surface them a bit and leave as is.

@iliapolo iliapolo requested a review from a team March 31, 2021 15:18
@gitpod-io
Copy link

gitpod-io bot commented Mar 31, 2021

@iliapolo iliapolo added the pr-linter/exempt-test The PR linter will not require test changes label Apr 2, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1eb558f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 567d64d into master Apr 2, 2021
@mergify mergify bot deleted the epolon/graduate-s3-deployment branch April 2, 2021 10:02
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Also fixed up some lint violations just for fun. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3-deployment contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants