Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(efs): graduate to stable 馃殌 #14033

Merged
merged 16 commits into from Apr 8, 2021
Merged

feat(efs): graduate to stable 馃殌 #14033

merged 16 commits into from Apr 8, 2021

Conversation

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Apr 7, 2021

Following #11242, we also want to enable encryption at rest by default.
Since switching to true requires a resource replacement, this PR introduces the default change behind a feature flag.

New projects created with cdk init will have encryption enabled by default, and existing projects won't be affected.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Apr 7, 2021

@iliapolo iliapolo marked this pull request as ready for review Apr 7, 2021
@iliapolo iliapolo requested review from aws/aws-cdk-team and NetaNir Apr 7, 2021
packages/@aws-cdk/aws-efs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/efs-file-system.ts Outdated Show resolved Hide resolved
@NetaNir
NetaNir approved these changes Apr 8, 2021
@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 8, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8be1848
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3c03d87 into master Apr 8, 2021
6 checks passed
6 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 1 rule matches and 5 potential rules
Details
@mergify mergify bot deleted the epolon/graduate-efs branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants