Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): create NAT Gateways with fixed IPs #14250

Merged
merged 5 commits into from Apr 21, 2021
Merged

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 19, 2021

Select static IPs for NAT gateways by pre-creating EIP allocations and
passing them into the NAT gateway provider.

Fixes #11884, fixes #4067.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Select static IPs for NAT gateways by pre-creating EIP allocations and
passing them into the NAT gateway provider.

Fixes #11884, fixes #4067.
@rix0rrr rix0rrr requested a review from aws/aws-cdk-team Apr 19, 2021
@rix0rrr rix0rrr self-assigned this Apr 19, 2021
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Apr 19, 2021

/**
* Properties for a NAT gateway
*
* @experimental

This comment has been minimized.

@nija-at

nija-at Apr 19, 2021
Contributor

I believe this is being banned. I believe, you have to either go with the new model of 'Pre' suffix or just take this as a stable API.

cc @NetaNir

This comment has been minimized.

@rix0rrr

rix0rrr Apr 19, 2021
Author Contributor

The APIs above and below also had @experimental still there, so seeing as no code change has been made here yet, I'd like to keep this in line with the rest.

This comment has been minimized.

@nija-at

nija-at Apr 19, 2021
Contributor

coordinate with @NetaNir on this. See #14071.

This comment has been minimized.

@NetaNir

NetaNir Apr 21, 2021
Member

@nija-at is right, we removed all @expiremental annotations and added a lint rule to disallow the use of this annotation. The PR for the removal was merged today, I was keeping it open to allow owners to make any adjustments before all APIs are marked as stable.

I pushed the change to remove the @experimetnal flag to your branch and merged in the latest changes from master.

If you want to keep this API non-final, you can add a preview suffix to both the method and the props. The preview API spec is not yet written but we had some discussion on this PR, in which it was decided to use the suffix beta1.

packages/@aws-cdk/aws-ec2/lib/nat.ts Show resolved Hide resolved
Copy link
Contributor

@nija-at nija-at left a comment

added label for second approver. Check with Neta on the experimental annotation.

Rest of the code LGTM.

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 21, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 423deaf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 24c992a into master Apr 21, 2021
7 checks passed
7 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@mergify
Rule: automatic merge (merge) The pull request has been merged automatically
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 1 rule matches and 5 potential rules
Details
@mergify mergify bot deleted the huijbers/nat-gateway-alloc-ids branch Apr 21, 2021
john-tipper added a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
Select static IPs for NAT gateways by pre-creating EIP allocations and
passing them into the NAT gateway provider.

Fixes aws#11884, fixes aws#4067.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants