-
Notifications
You must be signed in to change notification settings - Fork 4.3k
docs: fix typos and wording in feature flags description #35789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
FEATURE_FLAGS.md for clarity
FEATURE_FLAGS.md for clarityFEATURE_FLAGS.md for clarity
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments below
|
The file is generated from the source here: https://github.com/aws/aws-cdk/blob/main/packages%2Faws-cdk-lib%2Fcx-api%2Flib%2Ffeatures.ts Don't change it by hand, they won't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but this file is generated from another data source (some .ts file somewhere).
Search the code base for that original string and edit the other one.
Pull request has been modified.
FEATURE_FLAGS.md for clarityfeatures.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Build is failing, because you have uncommitted changes regarding FEATURE_FLAGS.md. You should include new generated FEATURE_FLAGS.md along with this PR
Pull request has been modified.
features.ts|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Corrected typos in feature flag documentation for clarity.
Clarified the explanation of the stabilization loop for Aspects.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license