From e25b6e304fcfdbbc87163000c578eb39bce6514e Mon Sep 17 00:00:00 2001 From: Noah Litov Date: Thu, 21 Nov 2019 18:57:53 -0800 Subject: [PATCH 1/4] fix: suggested semantic fixes from aaron --- .ionide/symbolCache.db | Bin 0 -> 8192 bytes .../%name.PascalCased%Stack.template.cs | 2 +- .../%name.PascalCased%Stack.template.cs | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 .ionide/symbolCache.db diff --git a/.ionide/symbolCache.db b/.ionide/symbolCache.db new file mode 100644 index 0000000000000000000000000000000000000000..8a73c4f77ed2b2c7b869d888125b966bab395731 GIT binary patch literal 8192 zcmeI#O-sWt7zglV2!b&1=3$rIR1h!v0qnL63T4x^2d~-8SRiRi`xM;Wiyy%6Yw9-e zZLMedKQx3iPtxSqT#`N{hO}7u(kT)*?38iN?u1~B@lbl9?4xNP?Hi$P+Filf^{wcK zEZ%=(;XyzE0uX=z1Rwwb2tWV=5P-mEftNKuJ{t`9>p7`~)#=79ysdUsZ#0)tCPfwv z6Df8tFZw6qTTG1AQ{}YC zozAzDbbjz&5$Upf3)!Y Date: Thu, 21 Nov 2019 19:11:35 -0800 Subject: [PATCH 2/4] remove ionide --- .ionide/symbolCache.db | Bin 8192 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .ionide/symbolCache.db diff --git a/.ionide/symbolCache.db b/.ionide/symbolCache.db deleted file mode 100644 index 8a73c4f77ed2b2c7b869d888125b966bab395731..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 8192 zcmeI#O-sWt7zglV2!b&1=3$rIR1h!v0qnL63T4x^2d~-8SRiRi`xM;Wiyy%6Yw9-e zZLMedKQx3iPtxSqT#`N{hO}7u(kT)*?38iN?u1~B@lbl9?4xNP?Hi$P+Filf^{wcK zEZ%=(;XyzE0uX=z1Rwwb2tWV=5P-mEftNKuJ{t`9>p7`~)#=79ysdUsZ#0)tCPfwv z6Df8tFZw6qTTG1AQ{}YC zozAzDbbjz&5$Upf3)!Y Date: Thu, 21 Nov 2019 19:45:29 -0800 Subject: [PATCH 3/4] access fix on Program.cs --- .../src/%name.PascalCased%/%name.PascalCased%Stack.template.cs | 2 +- .../app/csharp/src/%name.PascalCased%/Program.template.cs | 2 +- .../src/%name.PascalCased%/%name.PascalCased%Stack.template.cs | 2 +- .../csharp/src/%name.PascalCased%/Program.template.cs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs index 0f3268dcb24c7..415f2f65d1507 100644 --- a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs +++ b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs @@ -4,7 +4,7 @@ namespace %name.PascalCased% { public class %name.PascalCased%Stack : Stack { - public %name.PascalCased%Stack(Construct scope, string id) : base(scope, id) + internal %name.PascalCased%Stack(Construct scope, string id) : base(scope, id) { // The code that defines your stack goes here } diff --git a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs index 87a103bcb8816..ac2d31654a04a 100644 --- a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs +++ b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs @@ -7,7 +7,7 @@ namespace %name.PascalCased% { class Program { - static void Main(string[] args) + public static void Main(string[] args) { var app = new App(); new %name.PascalCased%Stack(app, "%name.PascalCased%Stack"); diff --git a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs index 8d67a281ad5e7..3bc903b936694 100644 --- a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs +++ b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs @@ -7,7 +7,7 @@ namespace %name.PascalCased% { public class %name.PascalCased%Stack : Stack { - public %name.PascalCased%Stack(Construct scope, string id) : base(scope, id) + internal %name.PascalCased%Stack(Construct scope, string id) : base(scope, id) { // The CDK includes built-in constructs for most resource types, such as Queues and Topics. var queue = new Queue(this, "%name.PascalCased%Queue", new QueueProps diff --git a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs index 0ef3d334917d4..fe258592f4f9e 100644 --- a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs +++ b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs @@ -4,7 +4,7 @@ namespace %name.PascalCased% { class Program { - static void Main(string[] args) + public static void Main(string[] args) { var app = new App(); new %name.PascalCased%Stack(app, "%name.PascalCased%Stack"); From 1f523d4176bc568dc73c3c1cca81424c666826d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=F0=9F=91=A8=F0=9F=8F=BC=E2=80=8D=F0=9F=92=BB=20Romain=20M?= =?UTF-8?q?arcadier-Muller?= Date: Fri, 22 Nov 2019 10:24:59 +0100 Subject: [PATCH 4/4] apply suggestions --- .../src/%name.PascalCased%/%name.PascalCased%Stack.template.cs | 2 +- .../app/csharp/src/%name.PascalCased%/Program.template.cs | 2 +- .../src/%name.PascalCased%/%name.PascalCased%Stack.template.cs | 2 +- .../csharp/src/%name.PascalCased%/Program.template.cs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs index 415f2f65d1507..6aadf6a3a0e05 100644 --- a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs +++ b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs @@ -4,7 +4,7 @@ namespace %name.PascalCased% { public class %name.PascalCased%Stack : Stack { - internal %name.PascalCased%Stack(Construct scope, string id) : base(scope, id) + internal %name.PascalCased%Stack(Construct scope, string id, IStackProps props = null) : base(scope, id, props) { // The code that defines your stack goes here } diff --git a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs index ac2d31654a04a..a2ce1b67fdd53 100644 --- a/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs +++ b/packages/aws-cdk/lib/init-templates/app/csharp/src/%name.PascalCased%/Program.template.cs @@ -5,7 +5,7 @@ namespace %name.PascalCased% { - class Program + sealed class Program { public static void Main(string[] args) { diff --git a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs index 3bc903b936694..365330ed65925 100644 --- a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs +++ b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/%name.PascalCased%Stack.template.cs @@ -7,7 +7,7 @@ namespace %name.PascalCased% { public class %name.PascalCased%Stack : Stack { - internal %name.PascalCased%Stack(Construct scope, string id) : base(scope, id) + internal %name.PascalCased%Stack(Construct scope, string id, IStackProps props = null) : base(scope, id, props) { // The CDK includes built-in constructs for most resource types, such as Queues and Topics. var queue = new Queue(this, "%name.PascalCased%Queue", new QueueProps diff --git a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs index fe258592f4f9e..20d5337f09888 100644 --- a/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs +++ b/packages/aws-cdk/lib/init-templates/sample-app/csharp/src/%name.PascalCased%/Program.template.cs @@ -2,7 +2,7 @@ namespace %name.PascalCased% { - class Program + sealed class Program { public static void Main(string[] args) {