Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-nodejs): parcel build cannot find target #8838

Merged
merged 3 commits into from Jul 1, 2020

Conversation

@jogold
Copy link
Contributor

jogold commented Jul 1, 2020

The PackageJsonManager was always targeting the package.json of
@aws-cdk/aws-lambda-nodejs and not the one closest to the entry file.

This was not detected in the tests inside the repo because both files
are the same.

Closes #8837


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jogold added 2 commits Jul 1, 2020
The `PackageJsonManager` was always targeting the `package.json` of
`@aws-cdk/aws-lambda-nodejs` and not the one closest to the entry file.

This was not detected in the tests inside the repo because both files
are the same.

Closes #8837
import { findUp } from '../lib/util';

test('findUp', () => {
expect(findUp('README.md')).toBe(process.cwd());

This comment has been minimized.

Copy link
@eladb

eladb Jul 1, 2020

Contributor

can we add a few more test cases here?

@mergify mergify bot dismissed eladb’s stale review Jul 1, 2020

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jul 1, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6714391
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb
eladb approved these changes Jul 1, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ce7a015 into aws:master Jul 1, 2020
5 checks passed
5 checks passed
build
Details
mandatory-changes
Details
AWS CodeBuild us-east-1 (AutoBuildProject6AEA49D1-qxepHUsryhcu) Build succeeded for project AutoBuildProject6AEA49D1-qxepHUsryhcu
Details
Semantic Pull Request ready to be squashed
Details
Summary 4 potential rules
Details
@jogold jogold deleted the jogold:lambda-nodejs-packagejson branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.