New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `aws cloudformation package` to work with local paths in `AWS::Include` transforms #2513

Open
nikolay opened this Issue Mar 28, 2017 · 14 comments

Comments

Projects
None yet
10 participants
@nikolay

nikolay commented Mar 28, 2017

No description provided.

@kyleknap

This comment has been minimized.

Member

kyleknap commented Mar 29, 2017

Marking as feature request. @sanathkr what's your thoughts on this?

@sanathkr

This comment has been minimized.

Contributor

sanathkr commented Mar 29, 2017

Great idea. Let's do it. PRs please :-)

@nikolay

This comment has been minimized.

nikolay commented Apr 11, 2017

@kyleknap @sanathkr It looks like this won't be so easy to implement as you guys have made assumptions in the current code that won't work with AWS::Include, which can literally be placed anywhere.

@nikolay

This comment has been minimized.

nikolay commented Jun 8, 2017

Any luck? This would be a huge improvement of the CloudFormation workflow, which is the main obstacle of people adopting CloudFormation widely!

@davidkelley

This comment has been minimized.

davidkelley commented Oct 20, 2017

Any update on this issue? It would be a fantastic feature to have.

@lafiosca

This comment has been minimized.

lafiosca commented Jan 22, 2018

@ASayre

This comment has been minimized.

Contributor

ASayre commented Feb 6, 2018

Good Morning!

We're closing this issue here on GitHub, as part of our migration to UserVoice for feature requests involving the AWS CLI.

This will let us get the most important features to you, by making it easier to search for and show support for the features you care the most about, without diluting the conversation with bug reports.

As a quick UserVoice primer (if not already familiar): after an idea is posted, people can vote on the ideas, and the product team will be responding directly to the most popular suggestions.

We’ve imported existing feature requests from GitHub - Search for this issue there!

And don't worry, this issue will still exist on GitHub for posterity's sake. As it’s a text-only import of the original post into UserVoice, we’ll still be keeping in mind the comments and discussion that already exist here on the GitHub issue.

GitHub will remain the channel for reporting bugs.

Once again, this issue can now be found by searching for the title on: https://aws.uservoice.com/forums/598381-aws-command-line-interface

-The AWS SDKs & Tools Team

This entry can specifically be found on UserVoice at: https://aws.uservoice.com/forums/598381-aws-command-line-interface/suggestions/33168370-allow-aws-cloudformation-package-to-work-with-lo

@ASayre ASayre closed this Feb 6, 2018

@jamesls

This comment has been minimized.

Member

jamesls commented Apr 6, 2018

Based on community feedback, we have decided to return feature requests to GitHub issues.

@jamesls jamesls reopened this Apr 6, 2018

@georgealton

This comment has been minimized.

georgealton commented Apr 11, 2018

this would be a major benefit as @lafiosca mentions the exact same problem i'm trying to solve :)

@ekcrisp

This comment has been minimized.

ekcrisp commented Jul 10, 2018

@sanathkr @lafiosca @georgealton @nikolay

I just submit a PR that would add this for inline swagger definitions on AWS::Serverless::Api resources. Adding it for arbitrary resources would be much more difficult, it seems this is the main use case though

#3440

@ekcrisp

This comment has been minimized.

ekcrisp commented Jul 17, 2018

Update: I have implemented this for arbitrary include transforms, not sure about my implementation approach, here is the PR, I will close the previous one if we decide to go ahead with this #3454

@ekcrisp

This comment has been minimized.

ekcrisp commented Aug 8, 2018

@kyleknap @sanathkr @joguSD @stealthycoin how do i go about getting my PR for this reviewed?
#3454

@jniedrauer

This comment has been minimized.

jniedrauer commented Aug 10, 2018

I also want this functionality. Let's get this merged!

@sanathkr

This comment has been minimized.

Contributor

sanathkr commented Nov 10, 2018

Looks like the PRis merged but the Issue is still open. Need to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment