feature/cfn-deploy-tag-support

[Posnet]

I have added support to the aws cloudformation deploy command for tags.
This ensures that change sets and their stacks are tagged correctly on create or update.

[JordonPhillips]

@sanathkr

[sanathkr]

Looks good to be merged! Thanks @Posnet for doing this

[vrivellino]

What happened here?

@Posnet: Any chance you can fix the conflicts?
@JordonPhillips & @sanathkr: Can we get a merge shortly there-after?

Would love to see #2324 resolved!

[Posnet]

@vrivellino are you an AWS employee? I am happy to fix the merge conflicts, but I would like to get an indication that it will actually get merged this time instead of just sitting here for months with no response.

[vrivellino]

@Posnet: Sorry, I'm not - just an AWS user looking for this feature hoping to spur some action.

Surprised to see that this PR was never merged. :(

[sanathkr]

@Posnet I am an AWS employee. I am reaching out to the concerned team internally to get this merged. Can you please resolve the merge conflicts? thanks!

[codecov-io]

Codecov Report

Merging #2620 into develop will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2620      +/-   ##
===========================================
- Coverage    95.69%   95.56%   -0.13%     
===========================================
  Files          159      151       -8     
  Lines        12024    11793     -231     
===========================================
- Hits         11506    11270     -236     
- Misses         518      523       +5

Impacted Files	Coverage Δ
awscli/customizations/cloudformation/deploy.py	100% <ø> (ø)	⬆️
awscli/customizations/cloudformation/deployer.py	96% <ø> (-0.3%)	⬇️
awscli/compat.py	68.83% <0%> (-8.53%)	⬇️
...customizations/cloudformation/artifact_exporter.py	97.15% <0%> (-0.26%)	⬇️
awscli/customizations/emr/createcluster.py	98.19% <0%> (-0.05%)	⬇️
awscli/customizations/s3/results.py	98.52% <0%> (-0.04%)	⬇️
awscli/customizations/s3/s3handler.py	97.76% <0%> (-0.03%)	⬇️
awscli/customizations/s3/filegenerator.py	98.9% <0%> (-0.02%)	⬇️
awscli/alias.py	99.05% <0%> (-0.01%)	⬇️
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9bc9e...0e43cf7. Read the comment docs.

[Posnet]

I have fixed the merge conflicts, just waiting on the ci now.

[Posnet]

Nevermind, I need to fix a bug in the testing.

[Posnet]

Tests are fixed

[sanathkr]

Thanks for fixing it!

[vrivellino]

@sanathkr Any chance this can get merged soon? :)

[Posnet]

@sanathkr is likely to ever be merged? I understand that maybe the Cfn deploy command should be refactored to just pass through args to create or update instead of having each one added piece meal like this pull request. In which case please close this pull request. The lack of communication is frustrating.

[dgcgh]

Is this missing some criteria for being merged?

[dgcgh]

can this be merged yet? is there anything I can do to help it be merged? if I talk to my TAMs could they have some influence over this getting merged?

[opsroller]

Merge!!!!!!!!

[corrjo]

@stealthycoin Can you help out?

[stealthycoin]

This got merged with #3106