don't set UsePreviousValue if parameters doesn't exist (fixes #2599) #2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
added
cloudformation package-deploy
pr:needs-review
Member
|
Could you have a look at this @sanathkr ? |
|
This is awesome, can we please review and merge? I'm having this exact issue as of version: |
tbhi
force-pushed
the
cf-deploy-use-existing-new-parameters
branch
from
16058c9 to
47ac543
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2659 +/- ##
===========================================
+ Coverage 95.92% 95.92% +<.01%
===========================================
Files 166 166
Lines 12579 12582 +3
===========================================
+ Hits 12066 12069 +3
Misses 513 513
Continue to review full report at Codecov.
|
sanathkr
added a commit
to sanathkr/aws-cli
that referenced
this pull request
Jan 23, 2018
awstools
added a commit
that referenced
this pull request
Jan 25, 2018
* release-1.14.31: Bumping version to 1.14.31 Update changelog based on model updates Fixing broken test caused by a merge of PR #2659 Removing stray print statement CloudFormation deploy tags should be in key=value format Fix tests fix error where tags are not being passed to create_change_set updated tests to handle new parameter Updated example command to include new tag argument Added Cfn stack tag support to the deploy command don't set UsePreviousValue if parameters doesn't exist (fixes #2599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2599