Cfn deploy tag support #3106
Merged
Cfn deploy tag support #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| True | ||
| ) | ||
|
|
||
| print self.deploy_command.parse_key_value_arg.call_args_list |
Contributor
There was a problem hiding this comment.
Rogue print statement.
Codecov Report
@@ Coverage Diff @@
## develop #3106 +/- ##
==========================================
Coverage ? 95.93%
==========================================
Files ? 166
Lines ? 12616
Branches ? 0
==========================================
Hits ? 12103
Misses ? 513
Partials ? 0
Continue to review full report at Codecov.
|
Contributor
Author
|
I happened to force git push to my fork which broke CodeCov's diff-level coverage. I assume this isn't a problem since |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
* Including stage resource yaml in pip. * Bumping patch version Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over #2620 and #3105. This PR modifies the tags parameter to be specified in
mykey=myvalueformat instead of the{Key="mykey", Value="myvalue"}format. This keeps the tags parameter format consistent with --parameter-overrides