Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the brand new 3.13 release of pyyaml #3430

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Allow the brand new 3.13 release of pyyaml #3430

merged 1 commit into from
Jul 10, 2018

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jul 6, 2018

reapply of #3414 but for just-released 3.13 instead

This enables awscli to be installable on python3.7

Note that 3.13 is essentially a re-release of 3.12 but with a newly cythonized _yaml.c file

@codecov-io
Copy link

codecov-io commented Jul 6, 2018

Codecov Report

Merging #3430 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3430      +/-   ##
===========================================
+ Coverage     94.4%   94.41%   +<.01%     
===========================================
  Files          169      169              
  Lines        13252    13252              
===========================================
+ Hits         12511    12512       +1     
+ Misses         741      740       -1
Impacted Files Coverage Δ
awscli/clidocs.py 98.58% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2782bfd...9d36245. Read the comment docs.

@IanAbildskou
Copy link

@clschnei
Copy link

clschnei commented Jul 9, 2018

Any status on this? Currently our CI/CD is blocked on it without downgrading our image to python@2.

Copy link
Contributor

@stealthycoin stealthycoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works fine, no travis entry for it yet though.

@asottile
Copy link
Contributor Author

asottile commented Jul 9, 2018

@stealthycoin I can add that in a separate PR or in this one -- imo orthogonal to allowing new pyyaml though :)

@stefansundin
Copy link

For the impatient:

pip3 install --user git+https://github.com/asottile/aws-cli.git@allow_new_pyyaml

@asottile
Copy link
Contributor Author

asottile commented Jul 9, 2018

fwiw, there's a single failure in python3.7:


FAIL: test_does_not_hard_fail_on_invalid_signature (tests.unit.customizations.cloudtrail.test_validation.TestDigestTraverser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/asottile/aws-cli/tests/unit/customizations/cloudtrail/test_validation.py", line 728, in test_does_not_hard_fail_on_invalid_signature
    calls[0]['message'])
AssertionError: 'Dige[48 chars]D: Incorrect padding' != 'Dige[48 chars]D: Invalid base64-encoded string: length canno[28 chars]of 4'
- Digest file	s3://1/20150810T000000Z.json.gz	INVALID: Incorrect padding
+ Digest file	s3://1/20150810T000000Z.json.gz	INVALID: Invalid base64-encoded string: length cannot be 1 more than a multiple of 4

@stealthycoin
Copy link
Contributor

stealthycoin commented Jul 9, 2018

@asottile Yep I see that now too. I ran in 3.6 on accident. So that needs to get figured out before this can be merged.

Edit: I guess that would be a blocking issue on adding the 3.7 travis entries not really this PR.

@asottile
Copy link
Contributor Author

asottile commented Jul 9, 2018

@stealthycoin why does that block this? pyyaml 3.13 works fine for the other supported python versions today

@stealthycoin
Copy link
Contributor

@asottile It isn't. I am currently running the branch through it through integration tests.

@asottile
Copy link
Contributor Author

@stealthycoin any updates on this? not sure why this is taking so long -- 3.13 is the same codebase as 3.12 it's just a version bump from the pyyaml side

@stealthycoin stealthycoin merged commit 6757c1a into aws:develop Jul 10, 2018
@asottile asottile deleted the allow_new_pyyaml branch July 10, 2018 16:56
@antonioned
Copy link

How about EB CLI? Is that changed to use pyyaml 3.13 when installed with pip? Cause I am still getting an error when using a docker python image on circleci with python 3.7.0.

gasman pushed a commit to wagtail/bakerydemo that referenced this pull request Oct 27, 2018
`awscli` version we used to pin depends on `pyyaml` that doesn't support py37

The issue got fixed in aws/aws-cli#3430

`botocore` is also updated as `awscli` and `botocore` should usually
be synchronized.
silveiralexf pushed a commit to silveiralexf/tlc-brazil that referenced this pull request Dec 26, 2018
`awscli` version we used to pin depends on `pyyaml` that doesn't support py37

The issue got fixed in aws/aws-cli#3430

`botocore` is also updated as `awscli` and `botocore` should usually
be synchronized.
webghost241 added a commit to webghost241/bakerydemo that referenced this pull request Jul 13, 2024
`awscli` version we used to pin depends on `pyyaml` that doesn't support py37

The issue got fixed in aws/aws-cli#3430

`botocore` is also updated as `awscli` and `botocore` should usually
be synchronized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants