Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update-kubeconfig during cluster update #4036

Open
wants to merge 1 commit into
base: develop
from

Conversation

@coryflucas
Copy link

commented Mar 31, 2019

Fixes #3914

Allows update-kubeconfig to run while cluster is either ACTIVE or UPDATING. Only ACTIVE was supported currently. Presumably this is because the UPDATING status did not exist when the functionality was added. I confirmed that all information required to build the kubeconfig is present in the DescribeCluster output while in the UPDATING status.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io

This comment has been minimized.

Copy link

commented Mar 31, 2019

Codecov Report

Merging #4036 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4036   +/-   ##
========================================
  Coverage    94.47%   94.47%           
========================================
  Files          187      187           
  Lines        14109    14109           
========================================
  Hits         13330    13330           
  Misses         779      779
Impacted Files Coverage Δ
awscli/customizations/eks/update_kubeconfig.py 98.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436d466...13642ca. Read the comment docs.

@coryflucas

This comment has been minimized.

Copy link
Author

commented Apr 19, 2019

Anything I can do to assist in getting this approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.