Add a new s3 website command. #482

Merged
merged 4 commits into from Nov 13, 2013

2 participants

@jamesls
Amazon Web Services member

This command allows you to set the website configuration for a bucket.
It currently only supports the index/error document. There's no support
for routing rules.

jamesls added some commits Nov 11, 2013
@jamesls jamesls Remove trailing whitespace a92a823
@jamesls jamesls Remove unused variables 5207986
@jamesls jamesls Add a new s3 website command
This command allows you to set the website configuration for a bucket.
It currently only supports the index/error document.  There's no support
for routing rules.
e12ad05
@garnaat garnaat commented on the diff Nov 12, 2013
tests/integration/customizations/s3/test_plugin.py
@@ -545,5 +545,19 @@ def test_transfer_single_large_file(self):
self.assert_max_memory_used(p, self.max_mem_allowed, download_full_command)
+class TestWebsiteConfiguration(BaseS3CLICommand):
+ def test_create_website_configuration(self):
+ bucket_name = self.create_bucket()
+ full_command = 's3 website %s --index-document index.html' % (bucket_name)
@garnaat
garnaat added a note Nov 12, 2013

Probably a good idea to test the error document, either here or in another test.

NVM, I see the tests below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@garnaat

This looks much better than my version.

@garnaat

LGTM

@jamesls jamesls merged commit 54d6c2e into aws:develop Nov 13, 2013

1 check passed

Details default The Travis CI build passed
@jamesls jamesls deleted the jamesls:s3-website branch Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment