Add scope/namespace option to CodeArtifact login

[ryansonshine]

Resolves #5291

Description of changes:

This change adds the ability to pass in a scope/namespace to CodeArtifact login.
The primary arg is namespace to remain generalized across different CodeArtifact
tools (ie: npm scope, maven groupid).

This change also includes:

• Throw error if namespace or scope are used for configuring pip
• Throw error if namespace or scope are used for configuring twine
• Throw error if namespace and scope are used at the same time
• Accept npm namespace value with or without "@" prefix for scope
• Add "@" prefix to npm scope if user has not passed it
• Validation on scope name to adhere with npm rules

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

Merging #5404 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #5404   +/-   ##
========================================
  Coverage    94.06%   94.07%           
========================================
  Files          190      190           
  Lines        14758    14780   +22     
========================================
+ Hits         13882    13904   +22     
  Misses         876      876           

Impacted Files	Coverage Δ
awscli/customizations/codeartifact/login.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e6103...dcee44d. Read the comment docs.

[danielgmyers]

Looks reasonable to me.

[kyleknap]

Looks good! Just had a couple of suggestions.

[kyleknap]

Looks great! Two more things that I forgot to mention in the last review before merging the PR:

1. Could you squash all of your commits into a single commit?
2. Could you add a changelog entry for this update? To do this, from the root directory of the repository, you can run the following commands to make an entry:

$ ./scripts/new-change -t enhancement -c '``codeartifact login``' -d 'Add support for ``--namespace`` parameter #5291' -r aws/aws-cli
$ git add .changes/next-release/
$ git commit

I can also make these changes and push to your branch as well and then merge the PR if you do not have time to get to it or want me to handle it. Let me know!

[KapitalEarth]

Looks great, @kylenap. We're about to ensure it's put ion the best tramsit, but shall squash commits. Would appreciate your kind offer to:

I can also make these changes and push to your branch as well and then merge the PR if you do not have time to get to it or want me to handle it.

Pretty sure the honey Beez Operating System V knows about this. Kind regards, Richard.

…

Sent from my iPhone

On 11 Aug 2020, at 12:44 PM, Kyle Knapp ***@***.***> wrote:  @kyleknap commented on this pull request. Looks great! Two more things that I forgot to mention in the last review before merging the PR: Could you squash all of your commits into a single commit? Could you add a changelog entry for this update? To do this, from the root directory of the repository, you can run the following commands to make an entry: $ ./scripts/new-change -t enhancement -c '``codeartifact login``' -d 'Add support for ``--namespace`` parameter #5291' -r aws/aws-cli $ git add .changes/next-release/ $ git commit I can also make these changes and push to your branch as well and then merge the PR if you do not have time to get to it or want me to handle it. Let me know! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ryansonshine]

Looks great! Two more things that I forgot to mention in the last review before merging the PR:

1. Could you squash all of your commits into a single commit?
2. Could you add a changelog entry for this update? To do this, from the root directory of the repository, you can run the following commands to make an entry:

$ ./scripts/new-change -t enhancement -c '``codeartifact login``' -d 'Add support for ``--namespace`` parameter #5291' -r aws/aws-cli
$ git add .changes/next-release/
$ git commit

I can also make these changes and push to your branch as well and then merge the PR if you do not have time to get to it or want me to handle it. Let me know!

Thanks @kyleknap . I've squashed my commits and added a changelog entry. Please let me know if you'd like me to make any additional changes.

[kyleknap]

Looks good! 🚢 Merging.