Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3 sync issue with keys containing urlencode values #755

Merged
merged 1 commit into from
Apr 18, 2014
Merged

Fix S3 sync issue with keys containing urlencode values #755

merged 1 commit into from
Apr 18, 2014

Commits on Apr 17, 2014

  1. Fix S3 sync issue with keys containing urlencode values 

    Fixes aws#749.  This was a regression from the fix for aws#675
where we use the encoding_type of "url" to workaround
the stdlib xmlparser not handling new lines.

The problem is that pagination in s3 uses the last key name as
the marker, and because the keys are returned urlencoded, we
need to urldecode the keys so botocore sends the correct next
marker.  In the case where urldecoded(key) != key we will incorrectly
sync new files.

Also added an integ test for syncing with '+' chars.
    @jamesls
    jamesls committed Apr 17, 2014
    Configuration menu
    Copy the full SHA
    1236dd2 View commit details
    Browse the repository at this point in the history