Fix f-string issue for older Python versions introduced in 2.32.0 #9854
+25
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewAsseily
approved these changes
Nov 19, 2025
Contributor
AndrewAsseily
left a comment
AndrewAsseily
left a comment
There was a problem hiding this comment.
Approved with a small nit. Assuming CI passes 🚢
| { | ||
| "type": "bugfix", | ||
| "category": "Source Distribution", | ||
| "description": "Fix Python 3.9 - 3.11 incompatibility that was introduce in 2.32.0" |
Contributor
There was a problem hiding this comment.
Nit: Small typo "introduce" -> "introduced"
kdaily
approved these changes
Nov 19, 2025
Member
Author
|
CI passed on 4ecf727 before the typo fix. |
kdaily
pushed a commit
to kdaily/aws-cli
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
2.32.0 introduced f-string syntax that only works in 3.12+ via https://peps.python.org/pep-0701/
This swaps the inner quotes so it still works on older versions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.