Use static MessageConfiguration tied to ServiceCollection #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendonparker
changed the title
|
@brendonparker - Thanks for your contribution! The team will review your PR as soon as possible. |
philasmar
approved these changes
Aug 12, 2024
96malhar
approved these changes
Aug 13, 2024
Contributor
|
Could you please use https://github.com/awslabs/aws-dotnet-messaging/blob/main/CONTRIBUTING.md to add a |
Contributor
Author
|
Done |
Contributor
|
@brendonparker Thanks for adding the |
Contributor
|
This PR was released as part of AWS.Messaging (0.9.2). Thank you @brendonparker for your contribution! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a way to support multiple invocations of AddAWSMessageBus against same ServiceCollection with the least amount of changes.
Submitting for feedback. Possible you may want to take a different approach.
Issue #152
Description of changes:
Change
MessageConfigurationto a static, so it can be shared across implementations.Add unit test for scenario and fix unit test scaffold to support setting up new
MessageConfigurationcontexts for each test.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.