Update path instructions post install #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaseAllbee
force-pushed
the
update-path-instructions
branch
from
4120f8d to
bad269b
Compare
ChaseAllbee
force-pushed
the
update-path-instructions
branch
from
bad269b to
ee06d55
Compare
Contributor
|
We should extract the functions and static variable names that are common to |
ChaseAllbee
force-pushed
the
update-path-instructions
branch
from
ee06d55 to
d4f3c64
Compare
ChaseAllbee
force-pushed
the
update-path-instructions
branch
from
d4f3c64 to
e7b28b1
Compare
rahulrajaram
reviewed
Sep 2, 2019
| PYTHON_ALREADY_IN_PATH=true | ||
| echo "" | ||
| echo_with_indentation " - $PYENV_BIN is already in PATH no further action need be taken." | ||
| if [ ${SUPPRESS_PATH_EXPORT_MESSAGE} = false ] ; then |
Contributor
There was a problem hiding this comment.
Curious to know why you made this change.
Contributor
Author
There was a problem hiding this comment.
I'm essentially trying to not have the python installer say anything regarding PATH unless it's been run. Like above, this is just a check to see if the script should suppress the output of messages regarding PATH.
rahulrajaram
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.