Load script fixes #884
Merged
Load script fixes #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
load-script-fixes
branch
from
848fe13 to
da94e3e
Compare
singholt
reviewed
Jan 2, 2025
| func getS3Object(s3Client *s3.S3, input *s3.GetObjectInput) *s3.GetObjectOutput { | ||
| obj, err := s3Client.GetObject(input) | ||
|
|
||
| func processFile(file *os.File, filePath string) (int, error) { |
Contributor
There was a problem hiding this comment.
not sure where this function is used.
swapneils
approved these changes
Jan 2, 2025
Contributor
swapneils
left a comment
swapneils
left a comment
There was a problem hiding this comment.
All non-blocking comments, so merging for now to unblock the current CVE release. Please respond/address-in-a-followup-PR when you can.
| break | ||
| } | ||
| if err != nil { | ||
| fmt.Println("[TEST ERROR] Malform log entry. Unmarshal Error:", err) |
Contributor
There was a problem hiding this comment.
Why are we no longer printing the failing entry?
| s3RecordCounter++ | ||
| value, err := strconv.ParseUint(recordId, 10, 32) | ||
| if err != nil { | ||
| fmt.Println("[TEST ERROR] Malform log entry. ParseUint Error:", err) |
Contributor
There was a problem hiding this comment.
Curious, why are we parsing the recordId now instead of using the raw value?
| continue | ||
| } | ||
| recordIdUint := uint32(value) | ||
| inputMap[recordIdUint] = struct{}{} |
Contributor
There was a problem hiding this comment.
Nit: Does this value need to be a struct, or would a true provide the same results? Seems the latter would be more memory-efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #, if available:
Testing
make debugsucceeded:Integ tests succeeded:
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.