SHADOW: Add support for named shadows #1087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 29, 2020 11:05
Signed-off-by: Andrés MANELLI <andres.manelli@zodiac.com>
|
Hi, @andresmanelli . Thank you for the PR. The changes do alter existing API calls, so that would require people using the library to update their code even if they don't use named shadows. One way to make these kind of changes without breaking existing code is to add new functions with slightly different names, then change the old API functions to call the new ones. The shadow library is actively undergoing refactoring, so this version will have no new features, only bug fixes. You can see the new code in this PR: #1081 . Your feedback would be welcome. The next iteration of the C SDK is on the development branch: https://github.com/aws/aws-iot-device-sdk-embedded-C/tree/development . Please join in the fun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The shadow name parameter was added to every function that needed that information in order to create the correct topic.
A NULL value falls back to the Classic Shadow topics.
Note: I know the interface is changed with this PR, so I am not sure if it can be integrated in the code base as-is, so please let me know if the changes aren't aligned with the contributing guidelines or if there is something I could improve.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.