pub_sub sample has missing dependencies

[netwerkz]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• I've searched for previous similar issues and didn't find any solution

Known Issue

• I'm using ATS data type endpoint: the endpoint should look like <prefix>-ats.iot.<region>.amazonaws.com

Describe the bug
Installing npm dependencies throws imports errors.

SDK version number
v1.2.1

Platform/OS/Hardware/Device
Windows 10/workstation PC

To Reproduce (observed behavior)
Run npm i.

Expected behavior
Installing npm deps should not error. Sample should work out of the box.

Logs/output

$ npm i

> aws-crt@1.1.8 install C:\workspace\nodejs\pub_sub\node_modules\aws-crt
> node ./scripts/install.js


> pub-sub@1.0.0 prepare C:\workspace\nodejs\pub_sub
> npm run tsc


> pub-sub@1.0.0 tsc C:\workspace\nodejs\pub_sub
> tsc


> pub-sub@1.0.0 tsc C:\workspace\nodejs\pub_sub
> tsc

index.ts:6:16 - error TS2305: Module '"./node_modules/aws-iot-device-sdk-v2/dist"' has no exported member 'auth'.

                 ~~~~
index.ts:6:22 - error TS2305: Module '"./node_modules/aws-iot-device-sdk-v2/dist"' has no exported member 'http'.

6 import { mqtt, auth, http, io, iot } from 'aws-iot-device-sdk-v2';
                       ~~~~

index.ts:6:28 - error TS2305: Module '"./node_modules/aws-iot-device-sdk-v2/dist"' has no exported member 'io'.

6 import { mqtt, auth, http, io, iot } from 'aws-iot-device-sdk-v2';
                             ~~

index.ts:6:32 - error TS2305: Module '"./node_modules/aws-iot-device-sdk-v2/dist"' has no exported member 'iot'.

6 import { mqtt, auth, http, io, iot } from 'aws-iot-device-sdk-v2';
                                 ~~~
index.ts:6:22 - error TS2305: Module '"./node_modules/aws-iot-device-sdk-v2/dist"' has no exported member 'http'.

6 import { mqtt, auth, http, io, iot } from 'aws-iot-device-sdk-v2';
                       ~~~~

index.ts:6:28 - error TS2305: Module '"./node_modules/aws-iot-device-sdk-v2/dist"' has no exported member 'io'.

6 import { mqtt, auth, http, io, iot } from 'aws-iot-device-sdk-v2';
                             ~~

index.ts:6:32 - error TS2305: Module '"./node_modules/aws-iot-device-sdk-v2/dist"' has no exported member 'iot'.

6 import { mqtt, auth, http, io, iot } from 'aws-iot-device-sdk-v2';
                                 ~~~

[bretambrose]

I am not able to reproduce this. We recently made a change to export all the crt modules from the sdk: https://github.com/aws/aws-iot-device-sdk-js-v2/blob/master/lib/index.ts#L22 Can you try a clean install of the sdk and report the results?

[netwerkz]

Ok @bretambrose . I did that but this is what node_modules/aws-iot-devide-sdk-v2/index.d.ts looks like for me:

/**
 * @moduledefinition aws-iot-device-sdk
 */
import * as iotidentity from './iotidentity/iotidentityclient';
import * as greengrass from './greengrass/discoveryclient';
import * as iotjobs from './iotjobs/iotjobsclient';
import * as iotshadow from './iotshadow/iotshadowclient';
import { mqtt } from "aws-crt";
export { iotidentity, greengrass, iotjobs, iotshadow, mqtt };

Why am I missing the rest of the exports?

This is how the package.json looks like:

{
    "name": "pub-sub",
    "version": "1.0.0",
    "description": "NodeJS IoT SDK v2 Pub Sub Sample",
    "homepage": "https://github.com/aws/aws-iot-device-sdk-nodejs-v2",
    "repository": {
        "type": "git",
        "url": "git+https://github.com/aws/aws-iot-device-sdk-js-v2.git"
    },
    "contributors": [
        "AWS SDK Common Runtime Team <aws-sdk-common-runtime@amazon.com>"
    ],
    "license": "Apache-2.0",
    "main": "./dist/index.js",
    "scripts": {
        "tsc": "tsc",
        "prepare": "npm run tsc"
    },
    "devDependencies": {
        "@types/node": "^10.12.18",
        "typescript": "^3.7.3"
    },
    "dependencies": {
        "aws-iot-device-sdk-v2": "^1.2.1",
        "yargs": "^14.0.0"
    }
}

[bretambrose]

On the surface, it looks like you're running the latest samples (which expect the crt modules to be exported by the sdk) against the 1.2.1 sdk which does not export them. I am making a new release in a few minutes, so once 1.2.2 posts, give it a clean, self-contained try.

[bretambrose]

1.2.2 should be available in npm now.

[netwerkz]

1.2.2 should be available in npm now.

Can confirm this patch fixed the issue. Thank you @bretambrose