Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable esbuild in the Node.js builder #307

Merged
merged 20 commits into from Jan 22, 2022

Conversation

mildaniel
Copy link
Contributor

Taking over the PR from #252. Thank you @gojko for the contribution!

Description from the original PR:

Issue #, if available:

Solves the following issues or makes them obsolete

Description of changes:

Support for ESBuild bundler running as part of the Nodejs NPM workflow, providing the following benefits:

  1. support for local directory dependencies and NPM7 relative references and sym linked node_modules
  2. support for TypeScript transpilation (.ts -> .js)
  3. support for minification (smaller bundle sizes)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CoshUS CoshUS self-requested a review November 10, 2021 00:12
@grahamlyons
Copy link

Super excited to see this go green.

@jfuss jfuss mentioned this pull request Nov 23, 2021
@totegi
Copy link

totegi commented Dec 22, 2021

This would be really nice

@falnyr
Copy link

falnyr commented Dec 29, 2021

@mildaniel any update on this? 🙏

@deepak7panwar
Copy link

@mildaniel please finish this!🙏

@mildaniel mildaniel requested a review from CoshUS January 6, 2022 21:31
Copy link
Contributor

@CoshUS CoshUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed cases for download_dependencies == false.
Added a full truth table for each possible combination.
Let me know if you have any question.

aws_lambda_builders/workflows/nodejs_npm/workflow.py Outdated Show resolved Hide resolved
aws_lambda_builders/workflows/nodejs_npm/workflow.py Outdated Show resolved Hide resolved
@mildaniel mildaniel requested a review from CoshUS January 20, 2022 19:30
Copy link
Contributor

@CoshUS CoshUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants