feat: add Python 3.14 and Java 25 runtimes #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnusunny
changed the title
bnusunny
changed the title
bnusunny
force-pushed
the
feature-java25-python314
branch
from
c29c2dd to
53a458c
Compare
seshubaws
reviewed
Oct 31, 2025
seshubaws
reviewed
Oct 31, 2025
tests/unit/test_validator.py
Outdated
| with self.assertRaises(UnsupportedRuntimeError): | ||
| validator.validate("/usr/bin/unknown_runtime") | ||
| """Test validation fails for completely unsupported runtimes""" | ||
| unsupported_runtimes = [ |
There was a problem hiding this comment.
i don't know if we need to test with all these unsupported runtimes, for the sake of test latency can we keep the list to 5? but very thorough though!
There was a problem hiding this comment.
Yes, it's not necessary. I removed them.
seshubaws
reviewed
Oct 31, 2025
seshubaws
previously approved these changes
Oct 31, 2025
vicheey
reviewed
Oct 31, 2025
vicheey
approved these changes
Oct 31, 2025
seshubaws
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes
Add Python 3.14 and Java 25 Runtimes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.